-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: remove backwards-compatible code for versions < 6.5 #38386
Conversation
Now that we require WordPress 6.5, we can remove any backwards-compatibility checks for folks that run WP 6.4. I also cleaned up some older stuff while I was looking. * js-packages/components: Remove a deprecation kept for 6.4 compat. * packages/jetpack-mu-wpcom: Simplify a test. * plugins/jetpack: Remove unnecessary `version_compare()` calls, assume WP 6.5+. * plugins/jetpack: Remove a check for us being Jetpack >=5.3. * plugins/jetpack: Remove some code checking for `JSON_BIGINT_AS_STRING` support, which was added in PHP 5.4. * plugins/jetpack: Address some `@todo` comments calling for action once WP 6.5 is the minimum. * plugins/wpcomsh: Remove unnecessary `version_compare()` calls, assume WP 6.5+. * plugins/wpcomsh: Remove some checks for old Jetpack versions. * plugins/wpcomsh: Remove a polyfill for WordPress before 5.4. * cli: Update some code for node 20.1+.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, thank you!
@@ -263,10 +262,9 @@ private static function get_gutenberg_initial_state() { | |||
// If Gutenberg is not installed, | |||
// check if we run a version of WP that would include support. | |||
if ( ! Constants::is_true( 'IS_GUTENBERG_PLUGIN' ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, I think we may be able to remove the whole logic around get_gutenberg_initial_state
and getGutenbergState
, it doesn't seem to be in use anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're probably right, AFAICT the one thing using it was removed in #33782.
Proposed changes:
Now that we require WordPress 6.5, we can remove any backwards-compatibility checks for folks that run WP 6.4.
I also cleaned up some older stuff while I was looking.
version_compare()
calls, assume WP 6.5+.JSON_BIGINT_AS_STRING
support, which was added in PHP 5.4.@todo
comments calling for action once WP 6.5 is the minimum.version_compare()
calls, assume WP 6.5+.Other information:
Jetpack product discussion
Epic: #36721
Does this pull request change what data or activity we track or use?
no
Testing instructions: