Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: remove backwards-compatible code for versions < 6.5 #38386

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jul 17, 2024

Proposed changes:

Now that we require WordPress 6.5, we can remove any backwards-compatibility checks for folks that run WP 6.4.

I also cleaned up some older stuff while I was looking.

  • js-packages/components: Remove a deprecation kept for 6.4 compat.
  • packages/jetpack-mu-wpcom: Simplify a test.
  • plugins/jetpack: Remove unnecessary version_compare() calls, assume WP 6.5+.
  • plugins/jetpack: Remove a check for us being Jetpack >=5.3.
  • plugins/jetpack: Remove some code checking for JSON_BIGINT_AS_STRING support, which was added in PHP 5.4.
  • plugins/jetpack: Address some @todo comments calling for action once WP 6.5 is the minimum.
  • plugins/jetpack: Remove support code for a feature removed in Lazy Images: remove from Jetpack plugin #33782.
  • plugins/wpcomsh: Remove unnecessary version_compare() calls, assume WP 6.5+.
  • plugins/wpcomsh: Remove some checks for old Jetpack versions.
  • plugins/wpcomsh: Remove a polyfill for WordPress before 5.4.
  • cli: Update some code for node 20.1+.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Epic: #36721

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • CI happy?
  • Check that the stuff being touched still works.

Now that we require WordPress 6.5, we can remove any
backwards-compatibility checks for folks that run WP 6.4.

I also cleaned up some older stuff while I was looking.

* js-packages/components: Remove a deprecation kept for 6.4 compat.
* packages/jetpack-mu-wpcom: Simplify a test.
* plugins/jetpack: Remove unnecessary `version_compare()` calls, assume WP 6.5+.
* plugins/jetpack: Remove a check for us being Jetpack >=5.3.
* plugins/jetpack: Remove some code checking for `JSON_BIGINT_AS_STRING` support, which was added in PHP 5.4.
* plugins/jetpack: Address some `@todo` comments calling for action once WP 6.5 is the minimum.
* plugins/wpcomsh: Remove unnecessary `version_compare()` calls, assume WP 6.5+.
* plugins/wpcomsh: Remove some checks for old Jetpack versions.
* plugins/wpcomsh: Remove a polyfill for WordPress before 5.4.
* cli: Update some code for node 20.1+.
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jul 17, 2024
@anomiex anomiex requested review from jeherve and a team July 17, 2024 17:57
@anomiex anomiex self-assigned this Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-wp-6.4-compat branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/remove-wp-6.4-compat
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-wp-6.4-compat
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

zinigor
zinigor previously approved these changes Jul 17, 2024
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thank you!

@@ -263,10 +262,9 @@ private static function get_gutenberg_initial_state() {
// If Gutenberg is not installed,
// check if we run a version of WP that would include support.
if ( ! Constants::is_true( 'IS_GUTENBERG_PLUGIN' ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I think we may be able to remove the whole logic around get_gutenberg_initial_state and getGutenbergState, it doesn't seem to be in use anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're probably right, AFAICT the one thing using it was removed in #33782.

@github-actions github-actions bot added the Admin Page React-powered dashboard under the Jetpack menu label Jul 18, 2024
@anomiex anomiex enabled auto-merge (squash) July 18, 2024 14:38
@anomiex anomiex merged commit e040fc9 into trunk Jul 18, 2024
72 checks passed
@anomiex anomiex deleted the update/remove-wp-6.4-compat branch July 18, 2024 16:38
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants