Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates wpcomsh to sync with version 3.22.13. #37848

Merged
merged 21 commits into from
Jun 13, 2024
Merged

Updates wpcomsh to sync with version 3.22.13. #37848

merged 21 commits into from
Jun 13, 2024

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Jun 13, 2024

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

zinigor and others added 18 commits June 13, 2024 17:10
@zinigor
Removed markdown file exclusion pattern.
593e91d
@zinigor @obenland
Add create_function polyfill (Automattic/wpcomsh#1894)
bbbd8fb 
* Add create function polyfill

* Add create function polyfill

* Add License

* Trigger a notice when it gets used

Notifies site owners and allows us to keep track of the sites using it.

Props @ebinnion
See pfuQfP-gV-p2/#comment-559

* See if unit tests work.

* Fix linter and failing test

* Convert deprecations to exceptions

* Revert test

---------

Authored-by: TimBroddin
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
@zinigor
Changelog.
60c855c
@zinigor
Bump to 3.22.7
8eeb438
@zinigor
Prevent non array/object from working (Automattic/wpcomsh#1901)
12edff2
@zinigor
Changelog.
db39758
@zinigor
Bump to 3.22.8.
6cf61e2
@zinigor
Fix: do not override text color if it is not set on the theme (Automa…
c0a0c9d 
…ttic/wpcomsh#1902)

* do not override text color if it is not set on the theme

---------

Co-authored-by: Andrés Blanco <email@gmail.com>
@zinigor
Changelog.
dbc7ff9
@zinigor
Bumped to 3.22.9.
bf6e47d
@zinigor
Update read access cookie arguments (Automattic/wpcomsh#1905)
a1b0756 
* Update read access cookie arguments
@zinigor
Changelog.
9e322a1
@zinigor
Bumped to 3.22.10.
780044f
@zinigor
Bumped to 3.22.11.
5f38572
@zinigor
Update language files and version bump to 3.22.12 (Automattic/wpcomsh…
65632d0 
…#1906)

* Update language files

---------

Co-authored-by: sdnunca <sorin@php.net>
@zinigor
Untangling: Remove temporary code that hides Hosting menu options (Au…
68d2626 
…tomattic/wpcomsh#1900)

* Remove temporary code

* Version bump to 3.22.13
@zinigor
Project versions.
7ec6372
@zinigor
Correct dates.
075136e
@zinigor zinigor requested a review from a team June 13, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Wpcomsh plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 13, 2024
anomiex
anomiex previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be a match for what's in the old wpcomsh repo.

@zinigor zinigor enabled auto-merge (squash) June 13, 2024 16:30
@zinigor zinigor merged commit efb7307 into trunk Jun 13, 2024
53 checks passed
@zinigor zinigor deleted the update/wpcomsh-3.22.13 branch June 13, 2024 17:03
tbradsha
tbradsha approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the changes match what are in the wpcomsh repo. I'm not sure why the create_function polyfill was added, though, as it's not used.

@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 13, 2024
@github-actions github-actions bot added this to the wpcomsh/3.22.6 milestone Jun 13, 2024
@anomiex
Copy link
Contributor

anomiex commented Jun 13, 2024

Automattic/wpcomsh#1894 doesn't give any more clue. It links to Automattic/wp-calypso#91005 which just says "Polyfilling create_function in WPCOMSH should fix some sites" with no indication of what sites or why they can't fix their code. 🤷

@tbradsha
Copy link
Contributor

Yep, I saw that. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

@tbradsha tbradsha tbradsha approved these changes

Assignees
No one assigned
Labels
Docs [Plugin] Wpcomsh
Projects
None yet
Milestone
wpcomsh/3.22.6
Development

Successfully merging this pull request may close these issues.
3 participants
@zinigor @anomiex @tbradsha