-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super Cache: notify Boost that migration is in progress #37797
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Super Cache plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Use a transient that can be checked after connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
This helps us move the migration forward.
Fire an action "jb_cache_moved_to_boost" that lets Jetpack Boost know of a migration from WPSC to Boost.
Fixes #37742
Proposed changes:
Other information:
Jetpack product discussion
pc9hqz-2QH-p2
Does this pull request change what data or activity we track or use?
Testing instructions:
No user visible changes as it sets a transient option.
Add this line to wpsc_ajax_activate_boost(), jsut above
wp_send_json_success();
Add the following mu-plugin to hook on the action and log the source:
Make sure that Boost is entirely deleted from the plugins directory and reload the WPSC settings page. If you have previously dismissed the Boost banner you will need to delete the wpsc_dismissed_boost_banner user option for your user.
Click the "Install Jetpack Boost" or "Activate Jetpack Boost" button and watch the error_log.