Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Cache: notify Boost that migration is in progress #37797

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

donnchawp
Copy link
Contributor

@donnchawp donnchawp commented Jun 11, 2024

Fire an action "jb_cache_moved_to_boost" that lets Jetpack Boost know of a migration from WPSC to Boost.

Fixes #37742

Proposed changes:

  • Create a function "wpsc_notify_migration_to_boost" that creates a transient option called "jb_cache_moved_to_boost" with a $source as the value.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pc9hqz-2QH-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

No user visible changes as it sets a transient option.
Add this line to wpsc_ajax_activate_boost(), jsut above wp_send_json_success();

	wpsc_notify_migration_to_boost( 'banner' );

Add the following mu-plugin to hook on the action and log the source:

function test_jb_cache_moved_transient() {
    if ( get_transient( 'jb_cache_moved_to_boost' ) ) {
        error_log( 'transient: ' . get_transient( 'jb_cache_moved_to_boost' ) );
    }
}
add_action( 'admin_init', 'test_jb_cache_moved_transient' );

Make sure that Boost is entirely deleted from the plugins directory and reload the WPSC settings page. If you have previously dismissed the Boost banner you will need to delete the wpsc_dismissed_boost_banner user option for your user.
Click the "Install Jetpack Boost" or "Activate Jetpack Boost" button and watch the error_log.

@donnchawp donnchawp added [Status] Needs Team Review [Plugin] Super Cache A fast caching plugin for WordPress. labels Jun 11, 2024
@donnchawp donnchawp self-assigned this Jun 11, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@donnchawp donnchawp requested a review from a team June 12, 2024 14:21
Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

This helps us move the migration forward.

:shipit:

@dilirity dilirity merged commit 737253c into trunk Jun 13, 2024
53 checks passed
@dilirity dilirity deleted the update/super-cache/notify-boost-migration branch June 13, 2024 13:37
@github-actions github-actions bot added this to the super-cache/1.12.1 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super Cache: Fire an action to notify Jetpack Boost that customer is moving cache
2 participants