Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter settings: add toggle for showing a subscribe modal after commenting #37699

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

Newsletter settings: add toggle for showing a subscribe modal after commenting #37699

wants to merge 8 commits into from
+60 −16

Commits on Jul 2, 2024

  1. Newsletter settings: add toggle for showing a subscribe modal after c… 

    …ommenting.
    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    02e4028 View commit details
    Browse the repository at this point in the history

  2. Attempt to enable for Jetpack sites

    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4149ed6 View commit details
    Browse the repository at this point in the history

  3. Add template preview & editing link

    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    783287c View commit details
    Browse the repository at this point in the history

  4. Enable in Jetpack rest API

    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    013f6fe View commit details
    Browse the repository at this point in the history

  5. Remove more limits, add platform-specific stats

    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    894d3e5 View commit details
    Browse the repository at this point in the history

  6. Keep old source value 

    The value might be misleading (due "atomic") but it serves simple, jetpack and atomic sites. There are dashboards created for the modal so it doesn't make sense to change this by platform.
    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    cfae384 View commit details
    Browse the repository at this point in the history

  7. Switch default to enabled in API

    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    47f20f9 View commit details
    Browse the repository at this point in the history

  8. Check for subscription module activation in should_show_subscription_… 

    …modal()
    @simison
    simison committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    69b796c View commit details
    Browse the repository at this point in the history