Node: match version used by WordPress itself

[kraftbj]

In https://core.trac.wordpress.org/ticket/59663, WordPress Core jumped from being pretty far behind on the LTS version of Node it required to 20.x, and specifically 20.10. To simplify things since we're close, what about us upping a tad to match?

Separately, would need to consider this for Calypso, but wanted to run it here for opinions first.

Proposed changes:

• Update nvmrc to 20.10 from 20.8.1
• Update package.json for the proper engine.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None as of now.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Run nvm use to update to 20.10 (possibly need nvm install first).
• Run pnpm install, jetpack install, jetpack build, etc to ensure things build right.
• Verify CI is happy.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/node-to-match-wporg branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/node-to-match-wporg
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/node-to-match-wporg
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[anomiex]

Wow, Gutenberg updated to node 20 too! 🎉

I don't see a problem with us bumping the version, other than the possibility of Calypso not doing so and the mismatch potentially being annoying.

[anomiex]

From their announcement post:

Will the required version be updated to 22.x when it’s released in April 2024?

Maybe.

I wonder if they'll decide to wait until 22.x becomes LTS in October, instead of doing it right away in April. If they do go ahead early, I wonder if we and Calypso should hold back until October as we've done previously.

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.