RNMobile: Ensure text is always visible within Contact Info block

[SiobhyB]

Fixes an issue with the Contact Info block within the app, in which typed text can sometimes be invisible.

The issue occurs when a block based theme is active with a background colour that contrasts with the device's light/dark mode. For example, if a theme's background is light while the device has dark mode enabled, the text will be white on white.

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#6341

Proposed changes:

• The logic associated with the block's text styles has been updated. If a block based theme is detected, its text colour will now be used to style text as its typed into the block.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

Follow the preparation steps once for each mode (dark/light) and then proceed with the testing steps.

Preparation steps

• Ensure the device is in either dark mode or light mode.
• Activate a theme with support for global styles, e.g. Byrne.
• In your site's /wp-admin area, navigate to the site editor (Appearance → Editor) and select a style corresponding to the opposite mode (dark background for light mode, and vice versa).
• In the app, navigate to the editor for any of the site's posts or pages.

Testing steps

• Tap the + icon to open the block inserter and add a Contact Info block.
• Type text into each of the block's fields.
• Verify that you're able to see the text you're typing into the block's fields.

Additional testing

• Ensure there are no regressions associated with non-block based themes i.e. dark mode should still retain dark styles and vice versa.

Screenshots

Dark mode + block based theme with light background ⤵️

Before	After

Light mode + block based theme with dark background ⤵️

Before	After

Non-block based themes ⤵️

Dark	Light

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the rnmobile/ensure-contact-info-text-visibility branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack rnmobile/ensure-contact-info-text-visibility
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[derekblank]

I was able to follow the testing instructions successfully. Thanks for addressing this! 🚀

[fluiddot]

@SiobhyB Similar to this comment, I managed to reproduce the issue related to this PR in version 23.8. However, in this case the issue is encountered when using the device's dark mode:

1. Go to the browser and activate Byrne theme.
2. Edit the Theme style and go to Styles -> Colors.
3. Check that the Background color is white (i.e. #FFFFFF).
4. Go to the app and ensure that the device's dark mode is active.
5. Create/open a post.
6. Add an Audio block.
7. Set the media for the block.
8. Observe that the text elements are not visible.

❌ Background color #FFFFFF	✅ Background color #FFFFFE	✅ Background color ##000000 (with text color set to white)

[SiobhyB]

Noting for posterity: Similar to this comment, I believe the issue highlighted by @fluiddot was resolved with the change in WordPress/gutenberg#56752.

Before	After