Add Jetpack Modules redux store to shared utils

[andrii-lysenko]

Fixes https://github.com/Automattic/vulcan/issues/12

Proposed changes:

In order to have a consistent state of Modules statuses across Monorepo I think it would be beneficial to have a Modules Redux store. This eventually could replace (or enhance) hook useModuleStatus and give more information.

• Creating Redux store for general information on Jetpack modules inside shared-extension-utils
• Use selector and dispatch action to control the module state within Form package (and block)
• Update withAiAssistantComponents HOC to use useIsPossibleToExtendJetpackFormBlock hook to have reactive data

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• Epic: Block discoverability: allow a block to be inserted even when its associated module is disabled #32401

Does this pull request change what data or activity we track or use?

Testing instructions:

• Clone this branch locally. You can run it with your Jurassic Tube setup.
• In /wp-admin/admin.php?page=jetpack_modules verify that Contact Form module is disabled
• Create new post /wp-admin/post-new.php and add new block

• Verify that no AI assistant present, when block is disabled
• Activate module. Verify that straight away the AI assistant is available

• Check any additional implications you could think of with the module or AI assistatnt

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/ai-assistant-form-blocks-sync branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/ai-assistant-form-blocks-sync
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/ai-assistant-form-blocks-sync
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[CGastrell]

Could use a .md with docs and examples/usage

[andrii-lysenko]

@CGastrell Thanks for pointing this out. Added basic Readme. However, we might change it a bit in the future, providing a more accessible experience utilizing the hooks.

[jeherve]

This doesn't seem to handle WordPress.com Simple just yet, where the contact form module is always active and that logic doesn't need to run.

I'm afraid this is still an issue on WordPress.com Simple:

[andrii-lysenko]

@jeherve oh, I haven't got this from the first time. Thanks, I'll take a look.

[andrii-lysenko]

@jeherve Sorry it took so long, due to ongoing support rotation. I pushed I believe a fix for this situation. The only thing does Atomic also considered simple? I'm wiring my logic around isSimpleSite() which I hope should be sufficient.

[jeherve]

The only thing does Atomic also considered simple? I'm wiring my logic around isSimpleSite() which I hope should be sufficient.

isSimpleSite() should be enough indeed! That's also what we do in useModuleStatus:

jetpack/projects/js-packages/shared-extension-utils/src/hooks/use-module-status/index.js

Lines 47 to 50 in ef15d7e

	// On WordPress.com Simple sites, all modules are always active.
	if ( isSimpleSite() ) {
	return true;
	}

[jeherve]

Shouldn't it return an object instead, to match the expected return?

[andrii-lysenko]

Oh, good catch. Though, it's error in JSDoc, it should yield object but returns bool.

[jeherve]

This tests well for me. 🚢 !