Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Extension: update proofread with the AI Status Indicator component #32397

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Aug 10, 2023

Fixes #

Proposed changes:

  • AI Extension: update proofread with the AI Status Indicator component

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the block editor
  • Use the proofread implementation
  • Confirm the AI Status Assistant icon shows in the Model header
Screenshot 2023-08-10 at 12 15 06
Screen.Recording.2023-08-10.at.12.10.11.mov

@retrofox retrofox requested a review from a team August 10, 2023 11:14
@retrofox retrofox self-assigned this Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/proofread-ai-assistant-status branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/proofread-ai-assistant-status
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA labels Aug 10, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: August 23, 2023.
  • Scheduled code freeze: August 21, 2023.

@retrofox retrofox added the [AI Feature] AI Extension Block editor extension feature label Aug 10, 2023
@nunyvega nunyvega force-pushed the update/proofread-ai-assistant-status branch from 4762b18 to 0d2081e Compare August 10, 2023 12:50
Copy link

@nunyvega nunyvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@retrofox retrofox merged commit 4acb09f into trunk Aug 10, 2023
52 of 53 checks passed
@retrofox retrofox deleted the update/proofread-ai-assistant-status branch August 10, 2023 13:36
@github-actions github-actions bot added this to the jetpack/12.5 milestone Aug 10, 2023
haqadn pushed a commit that referenced this pull request Aug 17, 2023
…cator component (#32397)

* [not verified] expose AiStatusIndicator component

* [not verified] use AiStatusIndicator in proofread implementation

* [not verified] changelog

* Update changelog

---------

Co-authored-by: Renato Augusto Gama dos Santos <renato_0603@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[AI Feature] AI Extension Block editor extension feature [Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants