Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jetpack Redirects in blocks links #23376

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

leogermani
Copy link
Contributor

Updates #15350

Replaces hard-coded links with links to use the Jetpack Redirect service.

Still have to check this issue raised by @kraftbj -> #15403 (comment)

Changes proposed in this Pull Request:

  • Replaces hard-coded links with links to use the Jetpack Redirect service.

Jetpack product discussion

#15403

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Test the affected blocks
  • Check that sources uses in the Redirects exist in the Redirect manager and point to the right place

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: May 3, 2022.
  • Scheduled code freeze: April 25, 2022.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since some of those links were hardcoded in tests, you'll need to update tests as well before we can merge this.

jeherve added a commit that referenced this pull request Mar 11, 2022
We'll do it for other links as well in #23376.
@samiff samiff added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 21, 2022
@github-actions github-actions bot added the [Block] Payments aka Unified Intro label Mar 21, 2022
@samiff samiff modified the milestones: jetpack/10.8, jetpack/10.9 Mar 28, 2022
@leogermani leogermani added [Status] Blocked / Hold and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Apr 12, 2022
@coder-karen coder-karen removed this from the jetpack/10.9 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants