Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled gallery: hide movers when only one image #14774

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Tiled gallery: hide movers when only one image #14774

merged 1 commit into from
Feb 24, 2020

Conversation

simison
Copy link
Member

@simison simison commented Feb 23, 2020

Small bugfix follow up to movers PR: #14702

Changes proposed in this Pull Request:

  • Hide tiled gallery image movers if there's just one image in gallery

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

  • Add Tiled gallery block with one image

  • Confirm you see movers placeholder:
    Screenshot 2020-02-23 at 23 21 54

  • Now re-build, confirm no movers:
    Screenshot 2020-02-23 at 23 08 46

  • Add another image, confirm movers are there on all layouts
    Screenshot 2020-02-23 at 23 17 40

Proposed changelog entry for your changes:

@simison simison added [Type] Bug When a feature is broken and / or not performing as intended [Block] Tiled Gallery labels Feb 23, 2020
@simison simison requested a review from a team as a code owner February 23, 2020 21:23
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39250-code before merging this PR. Thank you!

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against bbb0802

@simison simison added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 23, 2020
jeherve
jeherve approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added this to the 8.3 milestone Feb 24, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 24, 2020
@jeherve jeherve merged commit 8bb77eb into master Feb 24, 2020
@jeherve jeherve deleted the update/tiled-gallery-one-image-no-movers branch February 24, 2020 15:35
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 24, 2020
@jeherve
Copy link
Member

jeherve commented Feb 24, 2020

r203272-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@simison simison

Labels
[Block] Tiled Gallery Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
4 participants
@simison @matticbot @jetpackbot @jeherve