Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTable: update support doc links #14634

Merged
merged 1 commit into from
Feb 11, 2020
Merged

OpenTable: update support doc links #14634

merged 1 commit into from
Feb 11, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 11, 2020

Fixes #14347

Changes proposed in this Pull Request:

  • Update support doc link for both wpcom and Jetpack.

Testing instructions:

  • Start from a site running this branch.
  • Start a new post and insert an OpenTable block
  • Click the link at the bottom of the block placeholder: it should lead you to a 404 page on jetpack.com since the support doc has not been published yet.

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Cherry-Pick [Block] OpenTable labels Feb 11, 2020
@jeherve jeherve added this to the 8.2 milestone Feb 11, 2020
@jeherve jeherve requested a review from a team as a code owner February 11, 2020 13:03
@jeherve jeherve self-assigned this Feb 11, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38697-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 68c9af8

zinigor
zinigor approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 11, 2020
scruffian
scruffian approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jeherve jeherve merged commit 6127aa8 into master Feb 11, 2020
@jeherve jeherve deleted the add/opentable-support-links branch February 11, 2020 13:12
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 11, 2020
jeherve added a commit that referenced this pull request Feb 11, 2020
@jeherve
[not verified] OpenTable: update support doc links (#14634)
f3b5163 
Fixes #14347
@jeherve
Copy link
Member Author

jeherve commented Feb 11, 2020

Cherry-picked to branch-8.2 in f3b5163

@jeherve
Copy link
Member Author

jeherve commented Feb 11, 2020

r202681-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@zinigor zinigor zinigor approved these changes

Assignees

@jeherve jeherve

Labels
[Block] OpenTable Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.

OpenTable block: update support links in placeholder
5 participants
@jeherve @matticbot @jetpackbot @scruffian @zinigor