Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: Add My Home submenu to all Atomic sites #14590

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Feb 6, 2020

Changes proposed in this Pull Request:

We're enabling the Customer Home section to all WP.com sites created before Aug 2019 once this A/B test finishes.

This PR removes the dates check we were performing to determine if Customer Home was enabled for a given site, so the submenu link is always added to the masterbar.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

It modifies the WP.com masterbar module so Atomic sites will always get a Customer Home link on it. Needed after Automattic/wp-calypso#39265 lands (if the "show home in all sites" variant wins).

Testing instructions:

  • Install the Jetpack Beta plugin on 2 Atomic sites, one created before Aug 2019 and the other one created after Aug 2019.
  • Go to Jetpack > Jetpack Beta and activate the update/customer-home-all-sites feature branch.
  • Click on My Sites.
  • Make sure there is a Home item pointing to wordpress.com/home/:site on both sites.

Proposed changelog entry for your changes:

N/A

@mmtr mmtr added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations labels Feb 6, 2020
@mmtr mmtr requested a review from a team February 6, 2020 14:09
@mmtr mmtr requested a review from a team as a code owner February 6, 2020 14:09
@mmtr mmtr self-assigned this Feb 6, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against ca29386

@kwight
Copy link
Contributor

kwight commented Feb 6, 2020

Needed by Automattic/wp-calypso#39297.

Did you mean Automattic/wp-calypso#39071 ?..

Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmtr ! I verified that My Home appears for Atomic and not Jetpack sites.

Screen Shot 2020-02-06 at 1 50 42 PM

We'll want to hold off on merging this until Automattic/wp-calypso#39265 runs and we have a clear winner.

@mmtr
Copy link
Member Author

mmtr commented Feb 7, 2020

Needed by Automattic/wp-calypso#39297.

Did you mean Automattic/wp-calypso#39071 ?..

I meant Automattic/wp-calypso#39265 but I had pasted something else in the clipboard 😅

@mmtr mmtr added the DO NOT MERGE don't merge it! label Feb 7, 2020
@jeherve jeherve added [Status] Blocked / Hold and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 10, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 10, 2020
@jeherve jeherve removed this from the 8.3 milestone Feb 20, 2020
@mmtr
Copy link
Member Author

mmtr commented Mar 5, 2020

Alright, we can merge this now that Automattic/wp-calypso#39880 enabled the Customer Home section for all WP.com sites.

@jeherve is there a 8.3 point release planed or would this be included in 8.4?

@mmtr mmtr added [Status] Ready to Merge Go ahead, you can push that green button! and removed DO NOT MERGE don't merge it! [Status] Blocked / Hold labels Mar 5, 2020
@mmtr mmtr merged commit 1364e80 into master Mar 5, 2020
@mmtr mmtr deleted the update/customer-home-all-sites branch March 5, 2020 10:28
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 5, 2020
@jeherve
Copy link
Member

jeherve commented Mar 5, 2020

is there a 8.3 point release planed or would this be included in 8.4?

8.3 is already out. This will be in 8.4.

@jeherve jeherve added this to the 8.4 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants