-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masterbar: Add My Home submenu to all Atomic sites #14590
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: February 11, 2020. |
Did you mean Automattic/wp-calypso#39071 ?.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmtr ! I verified that My Home appears for Atomic and not Jetpack sites.
We'll want to hold off on merging this until Automattic/wp-calypso#39265 runs and we have a clear winner.
I meant Automattic/wp-calypso#39265 but I had pasted something else in the clipboard 😅 |
Alright, we can merge this now that Automattic/wp-calypso#39880 enabled the Customer Home section for all WP.com sites. @jeherve is there a 8.3 point release planed or would this be included in 8.4? |
8.3 is already out. This will be in 8.4. |
Changes proposed in this Pull Request:
We're enabling the Customer Home section to all WP.com sites created before Aug 2019 once this A/B test finishes.
This PR removes the dates check we were performing to determine if Customer Home was enabled for a given site, so the submenu link is always added to the masterbar.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
It modifies the WP.com masterbar module so Atomic sites will always get a Customer Home link on it. Needed after Automattic/wp-calypso#39265 lands (if the "show home in all sites" variant wins).
Testing instructions:
update/customer-home-all-sites
feature branch.wordpress.com/home/:site
on both sites.Proposed changelog entry for your changes:
N/A