Fix form submission with no name but mail (#40898)

* Fix form submission view if name field kept empty, email entry shows in name field

* add changelog entry

projects/packages/forms/changelog/try-fix-form-submission-with-no-name-but-mail

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Fix form submission view if name field kept empty, email entry shows in name field

projects/packages/forms/src/contact-form/class-contact-form-plugin.php

@@ -2046,10 +2046,7 @@ public static function parse_fields_from_content( $post_id ) {
 			if ( str_contains( $content, 'JSON_DATA' ) ) {
 				$chunks     = explode( "\nJSON_DATA", $content );
 				$all_values = json_decode( $chunks[1], true );
-				if ( is_array( $all_values ) ) {
-					$fields_array = array_keys( $all_values );
-				}
-				$lines = array_filter( explode( "\n", $chunks[0] ) );
+				$lines      = array_filter( explode( "\n", $chunks[0] ) );
 			} else {
 				$fields_array = preg_replace( '/.*Array\s\( (.*)\)/msx', '$1', $content );
 

projects/packages/forms/src/contact-form/class-contact-form.php

@@ -508,6 +508,14 @@ public static function get_compiled_form( $feedback_id, $form ) {
 
 				if ( $meta_key ) {
 					if ( isset( $content_fields[ "_feedback_{$meta_key}" ] ) ) {
+						if ( 'name' === $type ) {
+							// If a form contains both email and name fields but the user doesn't provide a name, we don't need to show the name field
+							// in the success message after submision. We have this specific check because in the above case the `author` field gets
+							// a fallback value of the provided email and is used in the backend in various places.
+							if ( isset( $content_fields['_feedback_author_email'] ) && $content_fields['_feedback_author'] === $content_fields['_feedback_author_email'] ) {
+								continue;
+							}
+						}
 						$value = $content_fields[ "_feedback_{$meta_key}" ];
 					}
 				} else {