Jetpack outdated WP notices: avoid fatals on outdated WP versions (#3…

…9745)
Automattic · Oct 18, 2024 · 7512e82 · 7512e82
1 parent f70f121
commit 7512e82
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 14 deletions.
diff --git a/projects/plugins/backup/changelog/revert-admin_notice_37051 b/projects/plugins/backup/changelog/revert-admin_notice_37051
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+General: ensure the notice displayed when running an old version of WordPress can always be displayed without errors.
diff --git a/projects/plugins/backup/jetpack-backup.php b/projects/plugins/backup/jetpack-backup.php
@@ -71,13 +71,15 @@ function jetpack_backup_requirements_check() {
 	add_action(
 		'admin_notices',
 		function () use ( $jetpack_backup_meets_requirements ) {
-			wp_admin_notice(
-				esc_html( $jetpack_backup_meets_requirements->get_error_message() ),
-				array(
-					'type'        => 'error',
-					'dismissible' => true,
-				)
-			);
+			?>
+		<div class="notice notice-error is-dismissible">
+			<p>
+				<?php
+				echo esc_html( $jetpack_backup_meets_requirements->get_error_message() );
+				?>
+			</p>
+		</div>
+			<?php
 		}
 	);
 

diff --git a/projects/plugins/jetpack/changelog/revert-admin_notice_37051 b/projects/plugins/jetpack/changelog/revert-admin_notice_37051
@@ -0,0 +1,4 @@
+Significance: patch
+Type: compat
+
+General: ensure the notice displayed when running an old version of WordPress can always be displayed without errors.
diff --git a/projects/plugins/jetpack/jetpack.php b/projects/plugins/jetpack/jetpack.php
@@ -116,13 +116,11 @@
 	 * @since 7.2.0
 	 */
 	function jetpack_admin_unsupported_wp_notice() {
-		wp_admin_notice(
-			esc_html__( 'Jetpack requires a more recent version of WordPress and has been paused. Please update WordPress to continue enjoying Jetpack.', 'jetpack' ),
-			array(
-				'type'        => 'error',
-				'dismissible' => true,
-			)
-		);
+		?>
+		<div class="notice notice-error is-dismissible">
+			<p><?php esc_html_e( 'Jetpack requires a more recent version of WordPress and has been paused. Please update WordPress to continue enjoying Jetpack.', 'jetpack' ); ?></p>
+		</div>
+		<?php
 	}
 
 	add_action( 'admin_notices', 'jetpack_admin_unsupported_wp_notice' );