Added null check post status obj in sal site class (#39727)

* Add null check for post_status_obj to avoid PHP Warnings * changelog * Ensure we only assign get_post_status_object to the parent status in case the parent exists
Automattic · Oct 10, 2024 · 41f0994 · 41f0994
1 parent 875d6d7
commit 41f0994
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/projects/plugins/jetpack/changelog/update-added-null-check-post-status-obj-in-sal-site-class b/projects/plugins/jetpack/changelog/update-added-null-check-post-status-obj-in-sal-site-class
@@ -0,0 +1,4 @@
+Significance: minor
+Type: other
+
+SAL_Site class: Added null check to posts_status_obj to avoid Warnings
diff --git a/projects/plugins/jetpack/sal/class.json-api-site-base.php b/projects/plugins/jetpack/sal/class.json-api-site-base.php
@@ -758,8 +758,8 @@ private function user_can_view_post( $post ) {
 		if ( ! $post || is_wp_error( $post ) ) {
 			return false;
 		}
-
-		if ( 'inherit' === $post->post_status ) {
+		// If the post is of status inherit, check if the parent exists ( different to 0 ) to check for the parent status object.
+		if ( 'inherit' === $post->post_status && 0 !== (int) $post->post_parent ) {
 			$parent_post     = get_post( $post->post_parent );
 			$post_status_obj = get_post_status_object( $parent_post->post_status );
 		} else {