feat(harper-ls): remove deleted file/s diagnostics #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
requested changes
Dec 5, 2024
mcecode
force-pushed
the
deleted-file-diagnostics
branch
from
760e004 to
8d4b0c5
Compare
|
Took me a while to get back to this but I think it's ready. It now also picks up deletions that happen outside of the editor. |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 22, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.14.0` -> `v0.16.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.16.0`](https://github.com/Automattic/harper/releases/tag/v0.16.0) [Compare Source](Automattic/harper@v0.15.0...v0.16.0) #### What's Changed - [A false-positive for subordinating conjunctions was resolved](Automattic/harper#341). - [harper.js now properly reexports types from harper-wasm](Automattic/harper@aad7519). - [harper.js now has an automatically generated API reference page.](https://writewithharper.com/docs/harperjs/ref/harper.js.html) - [Some erroneous filtering of certain errors was creating false-negatives.](Automattic/harper#131) - [Words containing numbers are less likely to throw false-positive spelling errors.](Automattic/harper#195) - [A rule for variations of the word “your” was added](Automattic/harper@113bc36). - fix the nvim-lspconfig link by [@​wadsaek](https://github.com/wadsaek) in Automattic/harper#367 - docs: added Scoop instructions by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#361 - Enable LTO and codegen-units = 1 in the Release profile by [@​zamazan4ik](https://github.com/zamazan4ik) in Automattic/harper#363 - feat([#​331](Automattic/harper#331)): Literate Haskell Support by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#344 - build(deps): bump dirs from 5.0.1 to 6.0.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#372 - build(deps): bump tokio from 1.42.0 to 1.43.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#371 - build(deps): bump thiserror from 2.0.9 to 2.0.11 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#369 - feat: Typst Language Support by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#302 - build(deps): bump serde_json from 1.0.134 to 1.0.135 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#368 - feat(core): create new linter for dollar sign placement by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#376 - refactor: Harper-ls Error-Handling Improvements by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#349 - feat([#​104](Automattic/harper#104)): Markdown linter config for ignoring link titles by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#305 - feat(harper.js): added ability to configure the markup language by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#379 - feat(vscode-plugin): Add Literate Haskell and Typst Support + some doc updates by [@​mcecode](https://github.com/mcecode) in Automattic/harper#388 #### New Contributors - [@​wadsaek](https://github.com/wadsaek) made their first contribution in Automattic/harper#367 - [@​elijah-potter](https://github.com/elijah-potter) made their first contribution in Automattic/harper#361 - [@​zamazan4ik](https://github.com/zamazan4ik) made their first contribution in Automattic/harper#363 **Full Changelog**: Automattic/harper@v0.15.0...v0.16.0 ### [`v0.15.0`](https://github.com/Automattic/harper/releases/tag/v0.15.0) [Compare Source](Automattic/harper@v0.14.0...v0.15.0) #### What's Changed - Added a variety of rules (see [complete list here](https://writewithharper.com/docs/rules)). - Fixed issues with parsing hostnames - Added a variety of available `Pattern`s for downstream use - Update +page.md by [@​aminwhat](https://github.com/aminwhat) in Automattic/harper#347 - feat: Add technical words to dictionary by [@​claydugo](https://github.com/claydugo) in Automattic/harper#343 - refactor: remove raw hashes that are unnecessary by [@​hamirmahal](https://github.com/hamirmahal) in Automattic/harper#324 - feat: Span View Command Improvements by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#340 - Address "one" for indefinite article rule by [@​claydugo](https://github.com/claydugo) in Automattic/harper#359 - feat: Add support for cmake files by [@​alcroito](https://github.com/alcroito) in Automattic/harper#353 - build(deps): bump itertools from 0.13.0 to 0.14.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#357 - feat(harper-ls): remove deleted file/s diagnostics by [@​mcecode](https://github.com/mcecode) in Automattic/harper#304 - feat(vscode-plugin): Add CMake Support by [@​mcecode](https://github.com/mcecode) in Automattic/harper#360 #### New Contributors - [@​aminwhat](https://github.com/aminwhat) made their first contribution in Automattic/harper#347 - [@​hamirmahal](https://github.com/hamirmahal) made their first contribution in Automattic/harper#324 - [@​alcroito](https://github.com/alcroito) made their first contribution in Automattic/harper#353 **Full Changelog**: Automattic/harper@v0.14.0...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTA3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCJdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that even after files are deleted, their diagnostics stay. This fixes that.