refactor: improvements to ProgressiveNeedsBe
#2232
Merged
+68
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
approved these changes
Nov 24, 2025
Collaborator
elijah-potter
left a comment
elijah-potter
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for getting this through. I think we can safely close #1753. Feel free to reopen if you think otherwise.
| panic!( | ||
| "Expected \"{transformed_str}\" to be \"{expected_result}\" after applying the computed suggestions." | ||
| ); | ||
| panic!("Expected \"{expected_result}\"\n But got \"{transformed_str}\""); |
Collaborator
There was a problem hiding this comment.
Yeah, this is easier to read.
| ProgressiveNeedsBe::default(), | ||
| &[ | ||
| "I've been playing with languages.toml", | ||
| "I'm playing with languages.toml", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1753
Description
I started working on #1753 and then realized it was already addressed by
ProgressiveNeedsBe.But my version could handle Ive/weve/youve/theyve with the apostrophes missing.
While adding those to the existing linter I identified a few opportunities to improve the code:
SequenceExpr.ignored unit tests.I also brought over all my unit tests.
I modified one of the suggestion assertions for clarify to align the expected and actual correction so we can see what's going wrong while working on linters.
How Has This Been Tested?
Unit tests.
Checklist