2056 -- Spell Checking Mode Option #2114
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g new lints with the new setting
Collaborator
|
@LoganBrinsmead, would you mind marking this as a draft until it's ready for review? If it is ready, say so and I'll review it as soon as I can. Thanks! |
…rper into 2056_SpellCheckingMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #2056
Description
This adds a new "spell checking" option to the Harper options. The "default" choice defaults to the current Harper behavior where incorrect words are highlighted immediately as they're being typed. "Space" option only suggests a correction to the previously typed word after hitting the spacebar, and finally the "Stop" option waits two seconds after the user stops typing before calculating and applying suggestions.
Demo
Will add video demonstrations to this PR very soon.
How Has This Been Tested?
Tested so far by typing in multiple websites including Github, blank page, and reddit and changes work across my tests.
Checklist