Skip to content

Conversation

@GaryJones
Copy link
Contributor

Summary

  • Add PHP syntax linting (composer lint-ci) to CI - catches parse errors
  • Add PHPCS coding standards check (composer cs) - reports violations as PR annotations

Details

The workflow runs on PRs and pushes, similar to existing workflows.

  • PHP syntax lint: Blocks on errors (parse errors should never be merged)
  • PHPCS: Non-blocking (continue-on-error: true) since there are existing violations to address over time

This provides visibility into PHP code quality issues via inline PR annotations using cs2pr.

Test Plan

  • Workflow runs successfully on this PR
  • PHPCS violations appear as annotations but don't block merge

🤖 Generated with Claude Code

Add a new GitHub Actions workflow that runs:
- PHP syntax linting via parallel-lint (blocks on errors)
- PHPCS coding standards check (non-blocking, reports only)

The PHPCS step uses continue-on-error since there are existing violations
to address. This provides visibility into code quality issues in PRs without
blocking merges.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@GaryJones GaryJones requested a review from a team as a code owner December 24, 2025 10:27
@GaryJones GaryJones self-assigned this Dec 24, 2025
@GaryJones GaryJones added the type: maintenance Routine maintenance and code quality improvements label Dec 24, 2025
@GaryJones GaryJones added this to the Next (minor) milestone Dec 24, 2025
@GaryJones GaryJones merged commit 42cb2fa into develop Dec 24, 2025
14 checks passed
@GaryJones GaryJones deleted the ci/add-php-lint-workflow branch December 24, 2025 10:35
@GaryJones GaryJones mentioned this pull request Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: maintenance Routine maintenance and code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants