Disable calendar li_html_cache object cache entirely because it's uggy and the solution to performance problems isn't object caching
#755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @jerclarke, could you please rebase this PR onto |
jerclarke
force-pushed
the
fix-calendar-object-cache
branch
from
3dcacd2 to
870ef4f
Compare
jerclarke
added a commit
to jerclarke/Edit-Flow
that referenced
this pull request
Dec 9, 2025
…gy and the solution to performance problems isn't object caching Re: Automattic#505 RE-DONE TO AVOID MERGE HELL Previous discussion: Automattic#755 My analysis of this issue points to bugs in what is being loaded in the HTML, rather than database queries, as the cause of slowness in the calendar, so there's no reason to "save" the object cache which is currently totally broken (it is never invalidated, so out-of-date post info just hangs around until the cache clears itself eventually). We should remove this cache ASAP so that the calendar is accurate, and deal with performance problems separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #505
My analysis of this issue points to bugs in what is being loaded in the HTML, rather than database queries, as the cause of slowness in the calendar, so there's no reason to "save" the object cache which is currently totally broken (it is never invalidated, so out-of-date post info just hangs around until the cache clears itself eventually).
We should remove this cache ASAP so that the calendar is accurate, and deal with performance problems separately.