Skip to content

Remove redundant jQuery selector #posts-filter input[type="submit"] #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
htdat wants to merge 2 commits into from
+1 −13
Closed

Remove redundant jQuery selector #posts-filter input[type="submit"] #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9445f2d
Remove redundant jQuery selector #posts-filter input[type="submit"
htdat Jun 15, 2021
82ad9e1
Remove #posts-filter as we don't use it
htdat Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/custom-status/lib/custom-status-configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ inlineEditCustomStatus = {
$('a.cancel', row).on( 'click', function() { return inlineEditCustomStatus.revert(); });
$('a.save', row).on( 'click', function() { return inlineEditCustomStatus.save(this); });
$('input, select', row).on( 'keydown', function(e) { if(e.which == 13) return inlineEditCustomStatus.save(this); });

$('#posts-filter input[type="submit"]').on( 'mousedown', function(e){
t.revert();
});
},

toggle : function(el) {
Expand Down
2 changes: 1 addition & 1 deletion modules/editorial-metadata/editorial-metadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,7 +1395,7 @@ function print_configure_view() {
<?php if ( !isset( $_GET['action'] ) || ( isset( $_GET['action'] ) && $_GET['action'] != 'edit-term' ) ): ?>
<div id="col-right">
<div class="col-wrap">
<form id="posts-filter" action="" method="post">
<form action="" method="post">
Copy link
Member Author

@htdat htdat Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two other modules Custom Statuses and User Groups do not have this element ID. So I think we may want to delete it and avoid confusion.

<?php $wp_list_table->display(); ?>
<?php wp_nonce_field( 'editorial-metadata-sortable', 'editorial-metadata-sortable' ); ?>
</form>
Expand Down
4 changes: 0 additions & 4 deletions modules/editorial-metadata/lib/editorial-metadata-configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ inlineEditMetadataTerm = {
$('a.cancel', row).on( 'click', function() { return inlineEditMetadataTerm.revert(); });
$('a.save', row).on( 'click', function() { return inlineEditMetadataTerm.save(this); });
$('input, select', row).on( 'keydown', function(e) { if(e.which == 13) return inlineEditMetadataTerm.save(this); });

$('#posts-filter input[type="submit"]').on( 'mousedown', function(e){
t.revert();
});
},

toggle : function(el) {
Expand Down
4 changes: 0 additions & 4 deletions modules/user-groups/lib/user-groups-configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ inlineEditUsergroup = {
$('a.cancel', row).on( 'click', function() { return inlineEditUsergroup.revert(); });
$('a.save', row).on( 'click', function() { return inlineEditUsergroup.save(this); });
$('input, select', row).on( 'keydown', function(e) { if(e.which == 13) return inlineEditUsergroup.save(this); });

$('#posts-filter input[type="submit"]').on( 'mousedown', function(e){
t.revert();
});
},

toggle : function(el) {
Expand Down