Remove redundant jQuery selector #the-list a.editinline #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeyarce
approved these changes
Jun 11, 2021
Contributor
mikeyarce
left a comment
mikeyarce
left a comment
There was a problem hiding this comment.
Thanks for this, @htdat !
I tested this out and Quick Edit works as expected. I'm curious as to why this was needed originally... My guess is it had something to do with what WordPress did maybe 10 years ago but is no longer the case.
Either way - Quick Edit custom statuses are loaded correctly and I'm able to select them, save them, change them, etc.
👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #662
Description
This is pretty straightforward as all research has been done in #662
Steps to Test
edit_flow.phpto avoid caching issue for JS files Fix jQuery warnings as WordPress upgraded it from 1.12.4-wp to 3.5.1 #649✅ if we can use
Quick Editand change custom status without any issue.