Skip to content

Fix: updating post slugs in Quick Edit and Classic Editor #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htdat merged 1 commit into from
Jun 4, 2021
Merged

Fix: updating post slugs in Quick Edit and Classic Editor #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions modules/custom-status/custom-status.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,10 +1373,9 @@ function fix_custom_status_timestamp( $data, $postarr ) {
* @since 0.9.4
*
* If the post_name is set, set it, otherwise keep it empty
*
* @see https://github.com/Automattic/Edit-Flow/issues/123
* @see http://core.trac.wordpress.org/browser/tags/3.4.2/wp-includes/post.php#L2530
* @see http://core.trac.wordpress.org/browser/tags/3.4.2/wp-includes/post.php#L2646
*
* @see https://github.com/Automattic/Edit-Flow/issues/523
* @see https://github.com/Automattic/Edit-Flow/issues/633
*/
public function maybe_keep_post_name_empty( $data, $postarr ) {
$status_slugs = wp_list_pluck( $this->get_custom_statuses(), 'slug' );
Expand All @@ -1389,7 +1388,7 @@ public function maybe_keep_post_name_empty( $data, $postarr ) {

// If the post_name was intentionally set, set the post_name
if ( ! empty( $postarr['post_name'] ) ) {
$data['post_name'] = $postarr['post_name'];
$data['post_name'] = sanitize_title( $postarr['post_name'] );
return $data;
}

Expand All @@ -1406,7 +1405,7 @@ public function maybe_keep_post_name_empty( $data, $postarr ) {
*
* `wp_unique_post_slug` is used to set the `post_name`. When a custom status is used, WordPress will try
* really hard to set `post_name`, and we leverage `wp_unique_post_slug` to prevent it being set
*
*
* @see: https://github.com/WordPress/WordPress/blob/396647666faebb109d9cd4aada7bb0c7d0fb8aca/wp-includes/post.php#L3932
*/
public function fix_unique_post_slug( $override_slug, $slug, $post_ID, $post_status, $post_type, $post_parent ) {
Expand Down