Remove status column on posts and post types, replace with default labels #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojennin
force-pushed
the
fix/custom-status-post-list
branch
from
4c92194 to
d826529
Compare
cojennin
force-pushed
the
fix/custom-status-post-list
branch
from
d826529 to
1429355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to put together some end-to-end testing to test whether the "—" was being removed correctly on the post and post types lists (see screenshot below for reference on the "—" I'm talking about) by the piece of JS we use to do that removal
But it doesn't seem worth the hassle, and instead I'm thinking we should just leverage the existing status labels. Moving the statuses to a separate column makes the statuses harder to differentiate. And by moving back to using the status labels, we can get rid of the hacks/workarounds we have in place. So it would look like: