Merge pull request #158 from dreinert1994/master

Fix strlen crashing when argument is not string
Automattic · Nov 23, 2021 · b5385ca · b5385ca
2 parents 2a4e6eb + 3ce6ac5
commit b5385ca
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -81,6 +81,7 @@ exports.options = options;
 // see: http://en.wikipedia.org/wiki/ANSI_escape_code
 //
 exports.strlen = function(str){
+  str = typeof str === 'string' ? str : String(str);
   var stripped = stripAnsi(str);
   var split = stripped.split("\n");
   return split.reduce(function (memo, s) { return (s.length > memo) ? s.length : memo }, 0);

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/util.test.js b/test/util.test.js
@@ -0,0 +1,21 @@
+/**
+ * Module requirements.
+ */
+
+require('should');
+
+var { strlen } = require('../lib/utils');
+
+/**
+ * Tests.
+ */
+
+
+ module.exports = {
+    'test strlen with string argument': function() {
+        strlen('hello\nme').should.equal(5);
+    },
+    'test strlen with number argument': function() {
+        strlen(5).should.equal(1);
+    },
+ }