Skip to content

Conversation

Copy link

Copilot AI commented Jan 13, 2026

The --global flag was silently overriding --targets when both were specified, causing unexpected behavior.

Changes

  • Add validation: Throw error when both --global and --targets are provided
  • Update help text: Clarify mutual exclusivity in usage documentation
# Now throws a clear error instead of silently using --global
node skillpack-install.mjs --targets=codex,vscode --global
# Error: Cannot specify both --global and --targets. Use --global alone or specify --targets without --global.

Validation is order-independent and occurs after argument parsing completes.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Jameswlepage <36246732+Jameswlepage@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on Claude Code support in skillpack scripts Prevent conflicting --global and --targets flags in skillpack-install Jan 13, 2026
Copilot AI requested a review from Jameswlepage January 13, 2026 01:39
" --skills=<list> Comma-separated skill names to install (default: all)",
" --mode=<mode> 'replace' (default) or 'merge'",
" --global Shorthand for --targets=claude-global (installs to ~/.claude/skills)",
" --global Shorthand for --targets=claude-global (cannot be used with --targets)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is --global only relevant for claude? I would think --global would be used in conjunction with: --targets=claude --global

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants