-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use theme colors for job overlay, improve dashboard on small screens #2810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I think the solution is impressive, I also think that we may overcomplicate things while trying to make things look consistent. Maybe we should focus on simply providing the elements and let users handle more opinionated styles like colors?
Is it possible that having CSS variables makes it harder for our users to modify the colors as they will need to figure out how we use them? On the other side, maybe having variables is a common thing now and in the end they can always override everything so maybe it's not big of an issue.
So regarding CSS variables, the new styles rely pretty heavily on it, and it makes it pretty easy to customize things with just a few variables. This is an alternative to rewriting or overriding everything with CSS, which is what they currently have to do. I'm putting together a documentation page with some examples to get started. This approach also makes it easy to add an UI on top in the future, where they can change the colors in the site editor or the setup wizard. This PR adds the color detections so styles are not broken out of the box on various themes. Most of it is for the new overlay modal, where we'd end up with stuff like white links on white background if it's a dark theme. |
Thanks for the review @gikaragia, all should be fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Changes Proposed in this Pull Request
Testing Instructions
New or Updated Hooks and Templates
job_manager_ui_theme_support_script
- disable theme color support scriptScreenshot / Video