Skip to content

Disable VariableAnalysis for phpcbf to speed up by 20% #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Disable VariableAnalysis for phpcbf to speed up by 20% #800

wants to merge 2 commits into from

Conversation

kkmuffme
Copy link

  • Disable VariableAnalysis for phpcbf to speed up by 20%
  • Also removes default "ruleset", as there's only one rule which is specifically declared, therefore making the ruleset redundant and causing problems with custom rulesets, that only declare the rule (with phpcs-only="true"), but not the ruleset itself, causing this ruleset to load variable analysis unnecessarily

@kkmuffme
Disable VariableAnalysis for phpcbf to speed up by 20%
f91f786 
Also removes default "ruleset", as there's only one rule which is specifically declared, therefore making the ruleset redundant and causing problems with custom rulesets, that only declare the rule (with phpcs-only="true"), but not the ruleset itself, causing this ruleset to load variable analysis unnecessarily
@kkmuffme kkmuffme requested a review from a team as a code owner September 27, 2023 11:16
@jrfnl
Copy link
Collaborator

jrfnl commented Jul 30, 2025

Why would this sniff get the phpcs-only="true" flag, while there are 40+ sniffs in VIPCS itself, which don't, while none of those contain fixers either ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkmuffme @jrfnl