Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: various tweaks #726

Merged
merged 2 commits into from
Oct 23, 2022
Merged

GH Actions: various tweaks #726

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eda678
GH Actions/basics: revert to xmllint-problem-matcher v1
jrfnl Oct 23, 2022
f41ca2b
GH Actions: harden the workflow against PHPCS ruleset errors
jrfnl Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
GH Actions: harden the workflow against PHPCS ruleset errors 
If there is a ruleset error, the `cs2pr` action doesn't receive an `xml` report and exits with a `0` error code, even though the PHPCS run failed (though not on CS errors, but on a ruleset error).

This changes the GH Actions workflow to allow for that situation and still fail the build in that case.
  • Loading branch information
@jrfnl
jrfnl committed Oct 23, 2022
commit f41ca2b4e4390002267c45ce084515d3bf01661a
3 changes: 2 additions & 1 deletion .github/workflows/basics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,11 @@ jobs:

# Check the code-style consistency of the PHP files.
- name: Check PHP code style
continue-on-error: true
id: phpcs
run: vendor/bin/phpcs --report-full --report-checkstyle=./phpcs-report.xml

- name: Show PHPCS results in PR
if: ${{ always() && steps.phpcs.outcome == 'failure' }}
run: cs2pr ./phpcs-report.xml

# Check that the sniffs available are feature complete.
Expand Down