chore: migrate to ESLint 9 with flat config #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration enables using @automattic/eslint-plugin-wpvip 1.0.0 which requires ESLint 9. The main driver is to unblock Dependabot PR #838. Changes: - Upgrade eslint from 8.56.0 to ^9.7.0 - Upgrade @automattic/eslint-plugin-wpvip from 0.13.1 to ^1.0.0 - Remove deprecated packages no longer needed with new plugin: babel-eslint, eslint-plugin-flowtype, eslint-plugin-wpcalypso - Convert .eslintrc.js to eslint.config.js (flat config format) - Remove .eslintignore (ignores now in eslint.config.js) - Fix glob 10.x compatibility in webpack.config.js (paths no longer include leading './') Note: Using individual configs instead of "recommended" to work around a bug in eslint-plugin-wpvip 1.0.0 where react-hooks config uses legacy plugins array format instead of flat config object format. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
GaryJones
added
the
type: maintenance
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates from ESLint 8 to ESLint 9 with the new flat config format, enabling the use of
@automattic/eslint-plugin-wpvip1.0.0.Key Changes
@automattic/eslint-plugin-wpvip0.13.1 → ^1.0.0babel-eslint(replaced by@babel/eslint-parserin the plugin)eslint-plugin-flowtype(not used in codebase)eslint-plugin-wpcalypso(functionality now in wpvip plugin).eslintrc.jstoeslint.config.js(flat config).eslintignorecontents intoeslint.config.jswebpack.config.jsto handle paths without leading./Notes
The config uses individual configs (
javascript,testing) instead ofrecommendedto work around a bug in@automattic/eslint-plugin-wpvip@1.0.0where the react-hooks config uses the legacy plugins array format instead of flat config object format.Related
This enables closing Dependabot PR #838 which was blocked by ESLint peer dependency conflicts.
Test plan
npm run lint-jspassesnpm run buildsucceeds🤖 Generated with Claude Code