Fix null event names and event properties #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxme
reviewed
Apr 13, 2017
| stmt.execute(); | ||
|
|
||
| db.setTransactionSuccessful(); | ||
| } catch(IllegalArgumentException e) { |
Contributor
There was a problem hiding this comment.
I think we should add our checkstyle config in this project (there is a missing space between catch and ()
Contributor
Author
|
Fixed the missing space. Yeah, we may want to add the checkstyle config. Maybe in another PR? |
Contributor
Yeah definitely not in that one, opened a ticket #31 |
Contributor
|
PR looks good, I'll publish a new version to bintray. We can update the dependency in wpandroid 7.2. |
This was referenced Apr 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an issue where passing an empty user to the library generates a bad crash.
I've also added other checks over the properties passed to the event, so the library should not crash if an invalid input is given.
Version number is also bumped, so we can release a new version of the library when this is merged to develop.
cc @maxme