Skip to content

Conversation

@Zayadul-huq-afnan
Copy link
Collaborator

@Zayadul-huq-afnan Zayadul-huq-afnan commented Aug 11, 2025

What does this PR do?

This PR adds playwright capabilities to the "close_tab" action. It also enables, closing tabs using tab title and tab index. If the tab title, or tab index is not provided, the the action will close the last active tab.

This action now takes "playwright" as an optional parameter. If the user provides "true" in the playwright parameter, then playwright will connect through a remote debugging port and perform this action. Otherwise, selenium will perform the action.

Related Ticket

Fixes #[https://dev.zeuz.ai/Home/EditTask/TASK-922/]

Testing

  • Unit tests added/updated
  • All tests passing locally
  • Manually tested with [https://qa.zeuz.ai/Home/ManageTestCases/Edit/TEST-11913/#parentHorizontalTab2]

Frontend Testing

  • Tested on Chrome
  • Tested on Firefox
  • Tested on Safari

Backend Testing

  • Tested with valid inputs
  • Tested with invalid inputs
  • Tested error scenarios
  • Tested with different user roles
  • Tested team/project isolation
  • Tested policy enforcement

Performance Impact

  • No significant performance impact
  • Performance improved (provide metrics)
  • Performance degraded but acceptable (explain why)

Screenshots (if UI changes)

[Add screenshots]

New Dependencies

⚠️ If new packages added:

  • Package: pytest-cov

  • License: MIT

  • Reason: Code coverage reporting for unit tests

  • Package: pytest-mock

  • License: MIT

  • Reason: Mocking capabilities for isolated unit testing

  • Package: pytest-html

  • License: MIT

  • Reason: HTML test report generation

  • Package: pytest-xdist

  • License: MIT

  • Reason: Parallel test execution for faster test runs

  • Package: coverage

  • License: Apache 2.0

  • Reason: Code coverage measurement and reporting

@Zayadul-huq-afnan Zayadul-huq-afnan self-assigned this Aug 11, 2025
@Muntasib-creator Muntasib-creator merged commit b4b64f7 into dev Aug 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants