Database Bug fix #203
Merged
Database Bug fix #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muntasib-creator
requested changes
Jun 30, 2022
| CommonUtil.ExecLog(sModuleInfo, "Got these browser_options", 2) | ||
| CommonUtil.ExecLog(sModuleInfo, browser_options, 2) | ||
| # CommonUtil.ExecLog(sModuleInfo, browser_options, 2) | ||
| print(f"\033[93m{browser_options}\033[0m") |
There was a problem hiding this comment.
revert this line
Muntasib-creator
approved these changes
Jul 4, 2022
…hon_Node into bug_fix � Conflicts: � Framework/Built_In_Automation/Web/Selenium/BuiltInFunctions.py
|
@Muntasib-creator CHANGELOG.md has been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Database bug fixed Bug fixPR_TYPE
PR Checklist
Overview
sid and service name is needed for oracle only. previously node gave error for not providing sid and service name in other database types too. Now added a check for oracle. N/A