Skip to content

Conversation

@sazid
Copy link
Member

@sazid sazid commented Jun 26, 2022

PR Type

Feature + Bug Fix

Overview

  • Fix attachments having same content but different file name not working properly
  • Attachments having same content will never be downloaded twice (even if they have different names, they are in different test cases or steps, etc.)
  • Use the hash as the file name so that the probability of collision is always the same as the probability of collision of the hash coming from server.
  • Attachments across different servers with same content will never be downloaded twice.

@sazid sazid self-assigned this Jun 26, 2022
@sazid sazid merged commit 312a3d4 into dev Jun 26, 2022
@sazid sazid deleted the attachment-hash-same-content-fix branch June 26, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants