Skip to content

Attachment db improvements #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2022
Merged

Attachment db improvements #197

merged 2 commits into from
Jun 24, 2022

Conversation

@sazid
Copy link
Member

@sazid sazid commented Jun 24, 2022

PR Type

Bug Fix

PR Checklist

  • Documentation comments have been added / updated.
  • (Team) Label with affected action categories and semver status.

Overview

Improves reliability of attachment db:

  1. Copies files with unique names to avoid problems where multiple test cases may
    have attachments with same file names but different content.
  2. If files got removed from attachment db folder or in case of other issues the system
    will now redownload the attachment.

@sazid sazid self-assigned this Jun 24, 2022
@sazid sazid changed the base branch from release to dev June 24, 2022 06:43
@sazid sazid merged commit 49829af into dev Jun 24, 2022
@sazid sazid deleted the attachment-db-improvements branch June 24, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oytizzo Oytizzo Awaiting requested review from Oytizzo

@Muntasib-creator Muntasib-creator Awaiting requested review from Muntasib-creator

Assignees

@sazid sazid

Labels

node-internals

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sazid