Repository navigation
fix: close post-merge trust and accessibility gaps - #101
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Closes trust and accessibility gaps from #99 by centralizing eligibility aliases, hardening generated-media detection, surfacing Discover failures, and correcting interaction semantics.
Changes:
- Shares canonical US/Canada eligibility normalization across validation and filtering.
- Restricts generated-media recognition to Sweepza hosts and propagates Discover read failures.
- Restores contrast, touch-target sizing, and single-main landmark behavior.
Validation: PR reports pnpm validate passing with 1,368 tests. No blockers identified; maintainer may perform final merge review.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lib/eligibility-country.ts |
Adds shared country normalization helpers. |
lib/us-state-codes.ts |
Reuses shared eligibility aliases. |
lib/listing-filters.ts |
Applies canonical US eligibility matching. |
lib/listing-media.ts |
Restricts fallback recognition to trusted hosts. |
lib/__tests__/workflow-route-boundaries.test.ts |
Checks Discover error propagation. |
lib/__tests__/listing-media-presentation.test.ts |
Covers external lookalike URLs. |
lib/__tests__/listing-filters.test.ts |
Covers eligibility aliases. |
lib/__tests__/interaction-accessibility.test.ts |
Adds accessibility contracts. |
components/public-footer.tsx |
Enlarges footer touch targets. |
components/mobile-shell.tsx |
Adds the role-workspace main landmark. |
components/listing-card.tsx |
Fixes target sizing and contrast. |
app/discover/page.tsx |
Routes listing failures to its boundary. |
app/admin/layout.tsx |
Removes the nested main landmark. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dfee632a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/__tests__/workflow-route-boundaries.test.ts (1)
56-62: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winExercise Discover failure propagation at runtime.
This source-text test can pass if the calls are later wrapped in a different catch/fallback. Add a test that mocks
getPublicListingsandgetCachedPublicListingsto reject, invokesDiscoverPagefor both filtered and default-feed inputs, and asserts that the returned promise rejects.As per coding guidelines,
**/*.{test,spec}.{ts,tsx}files must add tests for non-trivial logic.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/__tests__/workflow-route-boundaries.test.ts` around lines 56 - 62, Add runtime coverage to the Discover route tests by mocking both getPublicListings and getCachedPublicListings to reject, then invoke DiscoverPage with filtered and default-feed inputs and assert each returned promise rejects. Keep the existing source-text assertions, and place the behavioral cases in the applicable test file alongside them.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lib/__tests__/workflow-route-boundaries.test.ts`:
- Around line 56-62: Add runtime coverage to the Discover route tests by mocking
both getPublicListings and getCachedPublicListings to reject, then invoke
DiscoverPage with filtered and default-feed inputs and assert each returned
promise rejects. Keep the existing source-text assertions, and place the
behavioral cases in the applicable test file alongside them.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c2af649-9fc9-4e81-9d3b-187f4db5b328
📒 Files selected for processing (13)
app/admin/layout.tsxapp/discover/page.tsxcomponents/listing-card.tsxcomponents/mobile-shell.tsxcomponents/public-footer.tsxlib/__tests__/interaction-accessibility.test.tslib/__tests__/listing-filters.test.tslib/__tests__/listing-media-presentation.test.tslib/__tests__/workflow-route-boundaries.test.tslib/eligibility-country.tslib/listing-filters.tslib/listing-media.tslib/us-state-codes.ts
Summary
Verification
Follow-up to the completed review on #99.