Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1372 #1386

Merged
merged 4 commits into from
Sep 19, 2023
Merged

fix: #1372 #1386

merged 4 commits into from
Sep 19, 2023

Conversation

Siykt
Copy link
Contributor

@Siykt Siykt commented Sep 18, 2023

With the updated regular expression to support \"|\' , it should be able to handle scenarios where both single and double quotes are present. However, it's true that using only a regular expression might not cover all possible edge cases.

Test cases:

  1. s = "'',''" // ["''", "''"]
  2. s = "',',''" // ["','", "''"]
  3. s = "'\',',''" // ["'','", "''"]

@Kholid060 Kholid060 changed the base branch from main to dev September 19, 2023 04:55
@Kholid060 Kholid060 merged commit e10721a into AutomaApp:dev Sep 19, 2023
@Siykt Siykt deleted the fix/func-params-regexp branch September 25, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants