Skip to content

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Aug 14, 2025

Task

AARD-2080

Symptom

Currently there are a bunch of custom event classes with inconsistent implementations that both make it harder to find events and make the whole system more verbose. Unsubscription is also often done incorrectly or not done at all

Solution

I introduced an EventSystem class that manages all custom events and has generic create, dispatch, and listen methods.

Verification

Go through and try and trigger the list of events found in EventDataMap and confirm that they still work as before. This PR should not affect functionality


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz self-assigned this Aug 14, 2025
@rutmanz rutmanz added the refactor The most important part of software development. label Aug 14, 2025
@rutmanz rutmanz marked this pull request as ready for review August 14, 2025 23:19
@rutmanz rutmanz requested review from a team as code owners August 14, 2025 23:19
@rutmanz
Copy link
Member Author

rutmanz commented Aug 14, 2025

(because other open PRs add new events in ways that won't necessarily show up as conflicts, I'll want to do one last check before this is merged)

Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rutmanz rutmanz requested a review from azaleacolburn August 19, 2025 18:24
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some non-trival conflicts here. Since this is not user facing this will not be put in for v7.2.

@BrandonPacewic BrandonPacewic marked this pull request as draft August 29, 2025 04:48
@rutmanz
Copy link
Member Author

rutmanz commented Aug 30, 2025

Just merged dev and dealt with the conflicts

@BrandonPacewic BrandonPacewic marked this pull request as ready for review August 31, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The most important part of software development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants