Skip to content

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Aug 7, 2025

Task

Implement button sounds back in.

AARD-2054

Symptom

A lot of buttons stopped playing button SFX after the UI refactor.

Solution

Wrap the button mui component to make it so that any Button object would automatically play sounds.

Verification

All buttons play sounds.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 7, 2025
@AlexD717 AlexD717 requested a review from a team as a code owner August 7, 2025 20:44
@AlexD717 AlexD717 added the sound label Aug 7, 2025
@AlexD717 AlexD717 requested a review from a team as a code owner August 7, 2025 20:44
Copy link
Member

@ryanzhangofficial ryanzhangofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropdown sounds still aren't back, not sure if that's in scope. Otherwise LGTM

@AlexD717
Copy link
Member Author

AlexD717 commented Aug 8, 2025

Dropdown sounds still aren't back, not sure if that's in scope. Otherwise LGTM

I will probably make a different ticket for that

Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PepperLola PepperLola merged commit 7307511 into dev Aug 14, 2025
16 checks passed
@PepperLola PepperLola deleted the alexey/2054/button-sounds-fix branch August 14, 2025 00:10
@PepperLola PepperLola mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants