Extension Penalty [AARD-2011]
#1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD717
requested review from
rutmanz,
ryanzhangofficial,
PepperLola and
BrandonPacewic
5 tasks
ryanzhangofficial
approved these changes
Aug 1, 2025
BrandonPacewic
approved these changes
Aug 6, 2025
* 'dev' of github.com:Autodesk/synthesis: (53 commits) chore: fix build error Cleanup Remove any + lint fix(format): remaining format issues fix: added missing imports chore: formatting chore: restore some wrongly deleted files Add previous additions fix: merge issues fix: update bun lockfile Build Fix Merge Fix Documentation Linux build fix fix: run formatter refactor: add a variable. Update fission/package.json Synthesis App Icon Format Fix fix: mark schemes as customized when adding inputs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Create penalties for overextending beyond the allowed amount.
AARD-2011
Symptom
FRC has rules for extending beyond frame perimeter, but Synthesis has no penalties to support this.
Solution
The way it currently works is the starting size is recorded on match start, and then if the robot extends beyond the starting size + allowed extension a penalty is applied. This does mean that if the robot doesn't start in frame perimeter this will not work properly. However,
Verification
Tested with 2471 robot and moving the arm, with a custom match mode ruleset with an allowed extension of 0, and made sure that a penalty was still applied.
Before merging, ensure the following criteria are met: