Skip to content

Robot Falling of the Edge of the World [AARD-2034] #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

Robot Falling of the Edge of the World [AARD-2034] #1247

merged 4 commits into from
Aug 5, 2025

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Jul 31, 2025 •
edited by BrandonPacewic
Loading

Task

Currently robots can drive off the edge of the map and they will keep on following forever, which isn't something that we really want, as the only way to fix this is to reload the entire page.

AARD-2034

Symptom

You can drive a robot of the edge of the map, and then you are forced to reload the page, clearing everything that you have previously spawned.

Solution

Add a tracker that detects if a robots position has gone below the map boundary (constant), and in that case teleports it to its spawn position.

Verification

Driving of the edge of the map causes you to teleport back to the center

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Jul 31, 2025
@AlexD717 AlexD717 added the ui/ux Relating to user interface, or in general, user experience label Jul 31, 2025
@AlexD717 AlexD717 marked this pull request as ready for review July 31, 2025 16:18
@AlexD717 AlexD717 requested review from a team as code owners July 31, 2025 16:18
ryanzhangofficial
ryanzhangofficial approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@ryanzhangofficial ryanzhangofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

rutmanz
rutmanz approved these changes Jul 31, 2025
View reviewed changes
@AlexD717 @rutmanz
Update fission/src/systems/match_mode/RobotPositionTracker.ts
7d567e3 
Co-authored-by: Zach Rutman <zarutman+git@gmail.com>
azaleacolburn
azaleacolburn approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azaleacolburn azaleacolburn added the gameplay Relating to the playability of Synthesis label Jul 31, 2025
BrandonPacewic
BrandonPacewic reviewed Aug 1, 2025
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that this was added in the match mode directory? Does it not make sense outside of it?

@AlexD717 AlexD717 requested a review from BrandonPacewic August 1, 2025 22:15
@BrandonPacewic
Merge dev
3a47e22 
* dev:
  feat: scale drag mode torque by moment of inertia
  Can Unfocus Properly
  fix: formatting and removing extra code from another branch
  feat: moving util files into /lib/ and fixing imports
  Camera doesn't find focus if drag mode is transitioning
@BrandonPacewic BrandonPacewic mentioned this pull request Aug 5, 2025
Merged
@BrandonPacewic BrandonPacewic merged commit 1325c61 into dev Aug 5, 2025
16 checks passed
@BrandonPacewic BrandonPacewic deleted the alexey/2034/robot-falling-of-edge-of-map branch August 5, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaleacolburn azaleacolburn azaleacolburn approved these changes

@BrandonPacewic BrandonPacewic BrandonPacewic approved these changes

@rutmanz rutmanz rutmanz approved these changes

@ryanzhangofficial ryanzhangofficial ryanzhangofficial approved these changes

@Dhruv-0-Arora Dhruv-0-Arora Awaiting requested review from Dhruv-0-Arora Dhruv-0-Arora is a code owner automatically assigned from Autodesk/fission

@PepperLola PepperLola Awaiting requested review from PepperLola PepperLola is a code owner automatically assigned from Autodesk/synthesis-admin

Assignees

@AlexD717 AlexD717

Labels
gameplay Relating to the playability of Synthesis ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexD717 @azaleacolburn @BrandonPacewic @rutmanz @ryanzhangofficial