-
Notifications
You must be signed in to change notification settings - Fork 60
Unstick Button Input [AARD-2018]
#1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
I feel like unstick is kind of vague but I don't have any ideas on how to make it clearer without being too verbose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Zach's point, perhaps labelling as "Get Unstuck" would be more clearer? Looks good though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, unfortunately its going to have a minor conflict with the UI refactor (#1241), not 100% sure what our plan is for this but just going to wait on it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. An idea for another ticket would be to add a keybind (such as '/') that will show a list of commands (similar to discord's implementation)
* 'dev' of github.com:Autodesk/synthesis: (21 commits) fix(format): remaining format issues fix: added missing imports fix: resolve biome errors Upload File Accepts Only Mira Files fix: update bun lockfile fix: remove redundant test fix: remove git dependencies fix: refactoring issues fix: remove test artifacts fix: cleanup and format analytics tests feat: restructure analytics tests fix: firefox doesn't do analytics feat: add analytics testing feat: improve analytics tracking Fixed Promise Ordering: Download in parallel and then spawn in sequence. Order Promises Use 2023 Field Remove Unused Imports Format Fix Fix and New Access Strategy ...
Task
Add a new input that when pressed applies a slight upward force on the robot to get the robot unstuck when the robot is partially in the ground.
AARD-2018
Symptom
When playing on certain fields, the robot can sometimes get partially stuck in the ground, making it impossible to move. This is especially common if there is a slight bump or ledge. The current way to fix this is to right click on the robot, drag it up slightly and then let go, but this is tedious and takes too long to be a viable solution in multiplayer.
Solution
Add a new button that when pressed applies a slight upward force to the robot. This force isn't enough to give some sort of game advantage, but is strong enough to get the robot unstuck from the ground. A slider was also added in drivetrain configuration to allow the unstuck force to be customized for each robot.

Verification
Before merging, ensure the following criteria are met: