-
Notifications
You must be signed in to change notification settings - Fork 62
Added station selection #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Added station selection #1207
Conversation
…s/1988/station-selection
…s/1988/station-selection
Could we put this into this project's standard format for pull requests (#1187). |
fission/src/ui/panels/configuring/assembly-config/interfaces/AllianceSelectionInterface.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice. I especially like the fact that the color of the selected button changes with the alliance color. I'm assuming that more functionality will later be added (ex, spawning at driver station positions)
Thanks for the feedback! Yes, my current WIP is creating camera presets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't quite decide if this should go in at this point since we are still waiting for the UI refactor. Wondering what @PepperLola's preference is to updating the refactor with additional UI changes.
Task
AARD-1988
The task is to add a UI selection for a robots' alliance station.
Symptom
As we approach having a functional match mode, part of having fixed camera locations for players involves identifying unique positions for each player in the match. To give users more fine-grained control over their simulation, this feature allows users to pick each location instead of assigning them randomly.
Solution
Alongside alliance color selection, the user can now select the station number (from 1 to 3) of the focused robot, both in the initial config panel and the regular config panel.
Verification
I validated that the value updates and persists, through logging and visually in the UI. It follows the same hook structure as the Alliance selection.
Initial selection panel

Config sections (rephrased from "Alliance" to "Alliance / Station"

Inside the Alliance / Station menu
