APS Testing [AARD-1941]
#1206
Open
APS Testing [AARD-1941]
#1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APS IsSignedIn used to be returning true no matter what. This has no been fixed and APS.isSignedIn() now returns the proper result
AlexD717
requested review from
rutmanz,
ryanzhangofficial,
PepperLola and
BrandonPacewic
rutmanz
requested changes
Jul 10, 2025
ryanzhangofficial
requested changes
Jul 10, 2025
ryanzhangofficial
approved these changes
Jul 11, 2025
* dev: (28 commits) Unused Imports Removed Merge Fix fix(merge): fix merging build issues from GH-1203 Update fission/src/test/MirabufParser.test.ts New Endgame Sound & Updated Licensing Info fix: eslint fix: adding suggested changes Co-authored-by: Azalea Colburn <62953415+azaleacolburn@users.noreply.github.com> fix: comment position changes fix: eslint error fix: moving placement of comment Type & Removed Unnecessary Link Build Fix Documentation refactor: avoid having potentially undefined global functions fix: replacing empty fragment tag with null Cleaner Code Unnecessary Tests Removed fix: formatting feat: hides all touch control schemes if not supported by device More Advanced Joint Testing ...
* dev: fix(snyk): update version requirements reorder dependencies chore(installer): update python packages to avoid vulerabilities fix: clean up workflow spacing, use latest checkout and setup-node steps fix: use correct package.json path feat: add npm caching to all npm-involving workflows
BrandonPacewic
requested changes
Jul 11, 2025
…/synthesis into alexey/1941/APS-Testing
Comment on lines
+87
to
+90
| onClick={async () => { | ||
| const auth = await APS.getAuth() | ||
| auth && APS.refreshAuthToken(auth.refresh_token, true) | ||
| }} |
There was a problem hiding this comment.
I think the syntax is a little messed up here. I believe since auth is a promise it always is evaluated as truthly. For this reason I think an if statement is required but correct me if I'm wrong.
There was a problem hiding this comment.
auth isn't a promise here, it's APSAuth | undefined because APS.getAuth() is awaited. It's a bit unconventional to use short-circuiting in JS like this (more common in react components) but this does work
Dhruv-0-Arora
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Create Tests for APS.ts
AARD-1941
Symptom
No tests for the APS system
Solution
Add tests for the APS system
Verification
All Unit tests pass
Before merging, ensure the following criteria are met: