-
Notifications
You must be signed in to change notification settings - Fork 60
Bug: Hides touch control schemes if not supported by device AARD-1958
#1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan <ryzhangofficial@gmail.com>
ryanzhangofficial
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
rutmanz
approved these changes
Jul 9, 2025
Dhruv-0-Arora
commented
Jul 9, 2025
fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx
Outdated
Show resolved
Hide resolved
fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Azalea Colburn <62953415+azaleacolburn@users.noreply.github.com>
3c524b5
to
766e69b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
AARD-1958
Prevent all touch control schemes to appear in the ChooseInputSchemePanel when spawning a robot if the device does not support touch capabilities.
Symptom
If on any device, if spawning a robot assembly, the ChooseInputSchemePanel includes the "Brandon" touch control scheme. If selected, this scheme spawns in touch control joysticks which are impractical on a non-touch device. The only way to remove these is to clear all preferences since the MainHUD touch control button is hidden to all non-touch devices.
Solution
Hides all touch control schemes if on a non-touch device.
Verification
To test:
Before merging, ensure the following criteria are met: