Create Load Default Option for Field and Robot with Gizmo and Assembl…

[RoushilS]

AARD-1972

Description

Added a third button to initial Welcome Modal named Load Default that does the following

1. Loads in the field in cache with field.id equals "1750390764392" (FTC Field 2018 v13).

2. Loads in the robot in cache with robot.id equals "1750914383413" with Gizmo and Assembly Panel (Dozer v9).

Other button functionality remains the same.

New Welcome Modal:

Upon Clicking Load Default

[AlexD717]

This approach only works if the user has previously cached the robot and field files. On a user's first visit to the website, GetCacheInfo() returns an empty array, so nothing is spawned.

Additionally, each time an object is downloaded from the server, it is assigned a new ID. As a result, the id field cannot be reliably used to identify which field or robot should be spawned.

[ryanzhangofficial]

Ah I see that issue too now. I would look at the manifest in ImportMirabufPanel.tsx for a cleaner solution.

[RoushilS]

Ok, thanks for letting me know, @AlexD717 @ryanzhangofficial
My understanding is that the default robot and field data get loaded from the manifest, then get sent to the User's cache. They can be retrieved from the cache and spawned. However, the problem I'm finding is that the manifest object is located within ImportMirabufPanel, and there's currently only functionality for the User to cache the default fields and robots.
I am looking for a different method.

For the identification issue, is searching by name valid? This is from /api/mira/manifest.json

[AlexD717]

I would start by looking at the CacheRemote function in MirabufLoader.ts, I think that fetches the data from the remote. As for filtering by name, that should work.

[AlexD717]

Could you spawn the 2023 field instead of the 2018 field? Currently the robot gets spawned inside the center structure and is stuck there, while the 2023 field has no center object there.

[rutmanz]

The way these promises are set up means that the order isn't guaranteed and if the robot is spawned first, you have to configure/position it without seeing the field. I think it makes more sense to make sure the field spawns first. You can use Promise.all(...) here to do this and still let you download them both simultaneously

[AlexD717]

Looks good to me

[rutmanz]

This still doesn't guarantee order, because you're still spawning the files immediately after their respective promises resolve, rather than spawning synchronously after both cache requests resolve

MDN Promise.all()

[Dhruv-0-Arora]

Suggested change

	onClick={() => {
	closeModal()
	startSingleplayerCallback()
	Promise.all([
	MirabufCachingService.CacheRemote(
	"/api/mira/fields/FRC Field 2023_v7.mira",
	MiraType.FIELD
	).then(cacheInfoField => {
	if (cacheInfoField) {
	SpawnCachedMira(cacheInfoField, MiraType.FIELD)
	}
	}),
	MirabufCachingService.CacheRemote("/api/mira/robots/Dozer_v9.mira", MiraType.ROBOT).then(
	cacheInfoRobot => {
	if (cacheInfoRobot) {
	SpawnCachedMira(cacheInfoRobot, MiraType.ROBOT)
	}
	}
	),
	])
	onClick={() => {
	closeModal()
	startSingleplayerCallback()
	let cachedField: MirabufCacheInfo | undefined
	let cachedRobot: MirabufCacheInfo | undefined
	Promise.all([
	MirabufCachingService.CacheRemote(
	"/api/mira/fields/FRC Field 2023_v7.mira",
	MiraType.FIELD
	).then(cacheInfoField => {
	if (cacheInfoField) { cachedField = cacheInfoField }
	}),
	MirabufCachingService.CacheRemote("/api/mira/robots/Dozer_v9.mira", MiraType.ROBOT).then(
	cacheInfoRobot => { if (cacheInfoRobot) { cachedRobot = cacheInfoRobot } }
	),
	]).then(() => {
	if (cachedField && cachedRobot) {
	SpawnCachedMira(cachedField, MiraType.FIELD)
	SpawnCachedMira(cachedRobot, MiraType.ROBOT)
	}
	})
	}}

[Dhruv-0-Arora]

This is a solution you could look into for resolving zach's comment

[rutmanz]

the promise.all Promise returns the individual promise results as an array, you don't need to have cachedField and cachedRobot