Skip to content

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Jul 1, 2025

Description

The physics system unit test and mirabuf parser unit test were timing out when importing the 2471 robot due to the file size being to large. A new robot model was created that has all the joints but a small file size, allowing fast testing.

Testing Done

JIRA Issue

@AlexD717 AlexD717 self-assigned this Jul 1, 2025
@AlexD717 AlexD717 requested review from a team as code owners July 1, 2025 22:13
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the mirabuf format but it might be nice to check that the joint types are being parsed correctly (like you have 4 revolute and 2 slider)

@AlexD717 AlexD717 requested a review from rutmanz July 7, 2025 17:13
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexD717 AlexD717 requested a review from azaleacolburn July 8, 2025 23:18
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can I would like it if we could add some in code documentation regarding the magic floating test robot design that we now have in the cloud. Something to describe the structure of the design in a bit more detail and where said robot can be viewed from a developer perspective.

@AlexD717 AlexD717 requested a review from BrandonPacewic July 9, 2025 22:23
@AlexD717 AlexD717 requested a review from BrandonPacewic July 9, 2025 22:51
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
@AlexD717 AlexD717 requested a review from BrandonPacewic July 10, 2025 18:16
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost got all these tests done with now.

@BrandonPacewic BrandonPacewic mentioned this pull request Jul 10, 2025
@BrandonPacewic BrandonPacewic dismissed azaleacolburn’s stale review July 10, 2025 22:44

Suggested changes made.

@BrandonPacewic BrandonPacewic merged commit d765c84 into dev Jul 10, 2025
17 checks passed
@BrandonPacewic BrandonPacewic deleted the alexey/1971/new-test-robot branch July 10, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants