-
Notifications
You must be signed in to change notification settings - Fork 60
Multi Joint Robot Tests [AARD-1971]
#1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with the mirabuf format but it might be nice to check that the joint types are being parsed correctly (like you have 4 revolute and 2 slider)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can I would like it if we could add some in code documentation regarding the magic floating test robot design that we now have in the cloud. Something to describe the structure of the design in a bit more detail and where said robot can be viewed from a developer perspective.
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost got all these tests done with now.
Description
The physics system unit test and mirabuf parser unit test were timing out when importing the 2471 robot due to the file size being to large. A new robot model was created that has all the joints but a small file size, allowing fast testing.
Testing Done
JIRA Issue