Skip to content

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Jul 1, 2025

Description

Opens settings panel and resets quality settings to default if framerate is consistently below 10fps. Once quality presets are merged it could change pretty easily to reset them to the low preset instead of default

Objectives

  • Prevent users from getting stuck with high quality settings unable to change them back

Testing Done

  • Used chrome dev tools to simulate a slow machine on max quality settings

AARD-1928

@rutmanz rutmanz self-assigned this Jul 1, 2025
@rutmanz rutmanz requested review from a team as code owners July 1, 2025 16:05
@rutmanz rutmanz added the rendering Relating to the rendering engine or how something is rendered label Jul 1, 2025
@rutmanz rutmanz requested a review from Dhruv-0-Arora July 1, 2025 16:05
@rutmanz rutmanz added the ui/ux Relating to user interface, or in general, user experience label Jul 1, 2025
Co-authored-by: Azalea Colburn <62953415+azaleacolburn@users.noreply.github.com>
@rutmanz rutmanz requested a review from azaleacolburn July 1, 2025 16:57
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dhruv-0-Arora
Copy link
Collaborator

Make sure to fix conflicts and format but otherwise its good

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome good enough for me 📈

@BrandonPacewic BrandonPacewic mentioned this pull request Jul 1, 2025
@BrandonPacewic BrandonPacewic merged commit c4644c9 into dev Jul 1, 2025
15 checks passed
@BrandonPacewic BrandonPacewic deleted the zachr/1928/max-quality branch July 1, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rendering Relating to the rendering engine or how something is rendered ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants