Skip to content

Conversation

AlexD717
Copy link
Member

Description

Creates Unit Tests for World.ts

Testing Done

  • All unit tests pass

JIRA Issue

@AlexD717 AlexD717 self-assigned this Jun 30, 2025
@AlexD717 AlexD717 requested review from a team as code owners June 30, 2025 21:43
@AlexD717 AlexD717 requested a review from Dhruv-0-Arora June 30, 2025 21:43
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool, but I'm not sure how necessary it is, nearly everything tested here will self-evidently work based on very straightforward, high-level, infallible code. I don't see any technical issues, so if this' something we definitely want, I'll approve.

@AlexD717
Copy link
Member Author

There is a Jira issue for this task, which is why I made this. You are going to have to ask @BrandonPacewic

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool, but I'm not sure how necessary it is, nearly everything tested here will self-evidently work based on very straightforward, high-level, infallible code. I don't see any technical issues, so if this' something we definitely want, I'll approve.

I agree this code is unlikely to break, but I think it’s still worth including these tests. They’re lightweight, low-maintenance, and help ensure the basics keep working as expected. Plus, if we were building something more complex, this stage of testing would be expected, so it makes sense to include it here too, even if the utility is a bit lower given the current scale of the project.

@AlexD717 AlexD717 requested a review from azaleacolburn July 1, 2025 16:35
* dev:
  fix: finish merging and formatting
  doc(pr): remove code quality checkbox + whitespace removal
  doc(pr): update pull request template
  feat: move center of mass indicators to preference panel
  fix: make center of mass terminology consistent
  feat: add center of mass indicators and analysis tool panel
@BrandonPacewic BrandonPacewic mentioned this pull request Jul 1, 2025
@BrandonPacewic BrandonPacewic merged commit be20321 into dev Jul 1, 2025
15 checks passed
@BrandonPacewic BrandonPacewic deleted the alexey/1933/world-unit-tests branch July 1, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants