Preference System Unit Tests [AARD-1936]
#1181
Conversation
There was a problem hiding this comment.
Can you remove the console.log("Cleared all preferences") in the PreferenceSystem.ts file
/** Removes all preferences from local storage. */
public static clearPreferences() {
window.localStorage.removeItem(this._localStorageKey)
this._preferences = {}
console.log("Cleared all preferences")
}Makes sense to remove in this PR since it console logs when you are running the test.
Might be worth creating like a UI popup later that notifies the user that they cleared their preferences. |
If you want, I could add a toast that appears, it would be fairly easy |
There was a problem hiding this comment.
If you want, I could add a toast that appears, it would be fairly easy.
Not really worth it for this PR I don't think. This covers what we want, I think removing the console log is just fine considering we would want to remove all these logs anyways at a later date.
@Dhruv-0-Arora Can you re-review?
* dev: (67 commits) formatting fix: remove toast when saving configuration of ejectable docs(swerve): update repo owner to `Autodesk` docs(swerve): create swerve detection doc file fix: normalize all sound effects to -12dB Removed Console.log Bug Fix: Collision detects outside of protected zone MatchMode supports endgame Better Function Naming Removed Unused Import Remove casting docs(pr): add jira ticket id to pr request template fix: avoid relying on UMD globals for 3js fix: properly upgrade to threejs 0.178.0 fix: lock three.js to 0.165.0 to prevent crashing on import docs(exporter): revert link aard issue to new function docs(exporter): link aard issue to new function fix: update NOTICE.txt, remove external uses of SoundPlayer.play feat: check in new click sounds fix: reduce pitch on clickup sound ...
BrandonPacewic
dismissed
Dhruv-0-Arora’s stale review
Requested changes will not be a part of this PR.
Description
Implements and Expands Unit Tests for the Preference System.
Testing Done
JIRA Issue